strangechoice/ironbar-fork
1
0
Fork 0
Code Pull Requests Activity

fix(dynamic string): incorrectly handling strings containing multipoint utf-8 chars

Browse Source
This commit is contained in:
Jake Stanger
2023-07-30 23:30:24 +01:00
parent a47ec69a07
commit 2902331af0
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/dynamic_value/dynamic_string.rs
View File

@@ -144,7 +144,7 @@ fn parse_script(chars: &[char]) -> (DynamicStringSegment, usize) {
.map(|w| w[0])
.collect::<String>();
let len = str.len() + SKIP_BRACKETS;
let len = str.chars().count() + SKIP_BRACKETS;
let script = Script::from(str.as_str());
(DynamicStringSegment::Script(script), len)
@@ -160,7 +160,7 @@ fn parse_variable(chars: &[char]) -> (DynamicStringSegment, usize) {
.take_while(|&c| !c.is_whitespace())
.collect::<String>();
let len = str.len() + SKIP_HASH;
let len = str.chars().count() + SKIP_HASH;
let value = str.into();
(DynamicStringSegment::Variable(value), len)
@@ -173,15 +173,16 @@ fn parse_static(chars: &[char]) -> (DynamicStringSegment, usize) {
.map(|w| w[0])
.collect::<String>();
let mut char_count = str.chars().count();
// if segment is at end of string, last char gets missed above due to uneven window.
if chars.len() == str.len() + 1 {
let remaining_char = *chars.get(str.len()).expect("Failed to find last char");
if chars.len() == char_count + 1 {
let remaining_char = *chars.get(char_count).expect("Failed to find last char");
str.push(remaining_char);
char_count += 1;
}
let len = str.len();
(DynamicStringSegment::Static(str), len)
(DynamicStringSegment::Static(str), char_count)
}
#[cfg(test)]